[Bug 543940] Review Request: libmpdclient - Library for interfacing Music Player Daemon

bugzilla at redhat.com bugzilla at redhat.com
Fri Jan 8 20:58:38 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=543940





--- Comment #3 from Michal Nowak <mnowak at redhat.com>  2010-01-08 15:58:36 EDT ---
Created an attachment (id=382554)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=382554)
Proposed spec file changes

Would you consider this patch, please?


-Source: http://downloads.sourceforge.net/musicpd/libmpdclient-2.1.tar.gz
+Source: http://downloads.sourceforge.net/musicpd/%{name}-%{version}.tar.bz2

There's .tar.bz2 file upstream.

-%defattr (-,root,root)
+%defattr (-,root,root,-)
[...]
-%defattr (-,root,root)
+%defattr (-,root,root,-)

Was a bit old fashioned.

-%{_includedir}/mpd
+%{_includedir}/mpd/

Just a matter of taste.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list