[Bug 553705] Review Request: rinputd - A server for receiving input events over the network

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=553705





--- Comment #2 from Stefan Riemens <fgfs.stefan at gmail.com>  2010-01-08 16:17:30 EDT ---
Just a few notes before doing the official review:
- Why are you not using the %cmake macro?
- rpmlint is not silent:
[makerpm at laptop-stefan SPECS]$ rpmlint
/home/makerpm/rpmbuild/RPMS/i686/rinputd*.rpm rinputd.spec 
rinputd.i686: E: postin-without-chkconfig /etc/init.d/rinputd
rinputd.i686: E: init-script-without-chkconfig-preun /etc/init.d/rinputd
rinputd.i686: W: missing-lsb-keyword Required-Start in /etc/init.d/rinputd
rinputd.i686: W: missing-lsb-keyword Required-Stop in /etc/init.d/rinputd
rinputd.i686: W: missing-lsb-keyword Default-Stop in /etc/init.d/rinputd
rinputd.i686: W: service-default-enabled /etc/init.d/rinputd
rinputd.i686: E: subsys-not-used /etc/init.d/rinputd
rinputd-debuginfo.i686: E: debuginfo-without-sources
rinputd-devel.i686: W: non-standard-group Libraries/Development
rinputd-devel.i686: W: no-documentation
rinputd.spec:23: W: non-standard-group Libraries/Development
rinputd.spec: W: no-buildroot-tag
3 packages and 1 specfiles checked; 4 errors, 8 warnings.

I'm not saying everything can or should be fixed, but a couple of obvious ones
shouldn't be a problem.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.