[Bug 549496] Review Request: bakefile - A cross-platform, cross-compiler native makefiles generator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549496

Dan Horák <dan at danny.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #6 from Dan Horák <dan at danny.cz> 2010-01-09 06:47:43 EST ---
formal review is here, see the notes below:

BAD source files match upstream:
     bf8394d944fb34fdce8d5b82c891c180dc7af05e  bakefile-0.2.8.tar.gz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible (MIT). License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK rpmlint is silent.
BAD final provides and requires look sane.
BAD %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
BAD no libtool .la droppings.
OK not a GUI app.

- use http://download.sourceforge.net/%{name}/%{name}-%{version}.tar.gz as the
value of Source tag, the URL used doesn't lead to the source archive
- you must have automake as Requires for proper ownership of /usr/share/aclocal
directory where some files are placed
- a test-suite is included in the source archive, but it's not run
- _bkl_c.la file must not be included, use a "rm" command in %install or
%exclude in %files
- includes copies of uuid and subprocess python modules, system ones provided
by the python package or some add-on package must be used
- includes a copy of empy python module, this one must be packaged
independently

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.