[Bug 553186] Review Request: jansson - JSON parsing library

bugzilla at redhat.com bugzilla at redhat.com
Sun Jan 10 14:11:56 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=553186

Michael Schwendt <mschwendt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #3 from Michael Schwendt <mschwendt at gmail.com> 2010-01-10 09:11:52 EST ---
That did it.

Except for the  %doc doc/README  file which is still useless. "Plenty of other
packages" are poor examples, unfortunately. Better drop it because its contents
don't add any value at all.

If you're concerned about dropping a %doc file which may change to include
something useful in future upgrades, you could be smart and add a guard
somewhere in %prep which checks for a minimum size [or contents] of the file in
the tarball and terminates the build if a certain condition is met.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list