[Bug 554088] Review Request: pybox2d - A 2D rigid body simulation library for Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=554088

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tomspur at fedoraproject.org
         AssignedTo|nobody at fedoraproject.org    |tomspur at fedoraproject.org
               Flag|                            |fedora-review+

--- Comment #2 from Thomas Spura <tomspur at fedoraproject.org> 2010-01-11 03:41:34 EST ---
Review:

Good:
- name ok
- license ok
- sources match upstream (diff -r clean)
- BR ok
  (testbed needs some more, but that is not needed)
- rpmlint clean
$ rpmlint pybox2d-2.0.2-2.20100110svn.fc12.src.rpm x86_64/pybox2d-*
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

- %clean is there
- %install ok
  (calm rpmlint down, can't be moved to %prep)
- description ok
- permissions ok
- %files ok
- builds in koji:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1913399


Needswork:
- How to create the tarball...
  Copy paste of your command does not work... Remove the '|' and it'll work.
  'cd pybox2d' before svn export is also missing.
- use global and not define:
 
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define
- why is the group devel/languages?
  Development/Libraries would be more appropriate.
- %doc: please add 'doc/*'
  The online link for the manual is dead... Shipping is the only solution to
  get the manual.

#########################

Change the group to Development/Libraries, the rest is 'should'.


#########################

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.