[Bug 550690] Review Request: libsurl - A library for generating shortened URLs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550690

Michael Schwendt <mschwendt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mschwendt at gmail.com

--- Comment #4 from Michael Schwendt <mschwendt at gmail.com> 2010-01-11 07:41:03 EST ---
> Group:          Applications/Internet

Shared libraries like this still belong into "System Environment/Libraries".


> %{_mandir}/man*/*.gz

Since manual pages are compressed on-the-fly by rpmbuild and the compression
tool may change, prefer:  %{_mandir}/man*/*

And move these manual pages into the -devel pages, since they document the
library API.


> %files
> %defattr(-,root,root,-)
> %doc AUTHORS ChangeLog COPYING NEWS README

> %files devel
> %defattr(-,root,root,-)
> %doc ChangeLog

Why duplicate the ChangeLog? Including it in just the base package is fine.


> #Tests deactivated because the library checks online URLs
> #%check
> #make check

A good opportunity to make this a conditional build, so you could simply
activate the test-suite for local builds with "rpmbuild --with tests
libsurl.src.rpm":

%bcond_with tests
%if %{with tests}
%check
make check
%endif


* The %description mentions "surl" without explaining that it is a separate
tool to be found in a separate package ("surl").


* The web page mentions that the latest stable release is 0.6.0. No comment is
found on 0.7.0 and 0.7.1, not in the tarball either. I've mailed a question
about that to the author.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.