[Bug 543425] Review Request: gource - Software version control visualization

bugzilla at redhat.com bugzilla at redhat.com
Mon Jan 11 18:19:34 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=543425

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp

--- Comment #14 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-01-11 13:19:29 EST ---
Well,

* Version specific BuildRequires
  - %sdl_image_version, %sdl_version are not needed because
    SDL{_image} packges in currently supported Fedora branch
    all satisfies this depedency

  ! For ftgl, F-11 ftgl is still 2.1.2, so you may want to
    write this version specific BuildRequires.

* Virtual BuildRequires
  - For some reasons, we prefers to use
    - "BuildRequires: libGL-devel" instead of mesa-libGL-devel
    - and "libGLU-devel" instead of mesa-libGLU-devel

* Preserving timestamps
  - Using alias won't work when using Makefile because the
    subprocess executed by make won't recognize such shell
    builtin commands.

    For this case you have to modify Makefile.in directly
    at %prep like;
---------------------------------------------------
%prep
%setup -q
sed -i.cp -e 's|cp |cp -p |' Makefile.in
---------------------------------------------------

* Enclosed fonts
  - Currently Fedora bans to use fonts enclosed in the non-font
    source tarball and you must use fonts provided from
    font related rpms shipped in Fedora.

    Fedora uses dejanu fonts by default. If you choose to
    use /usr/share/fonts/dejavu/DejaVuSans.ttf (in 
    dejavu-sans-fonts rpm), you have to
    - Add "Requires: dejavu-sans-fonts" to this rpm
    - Replace FreeSans.ttf under %_datadir/gource/fonts/ to
      the symlink to DejaVuSans.ttf.

%files entry
  - For example %files contains
---------------------------------------------------
%files
%dir %{_datadir}/gource/fonts/*
---------------------------------------------------
    However the installed objects under %{_datadir}/gource/fonts/
    is actually a file, not a directory. So here using %dir
    is wrong.

    ! Note:  As I said above, this file should be replaced with
             a symlink
    ! Note2: You may say "but actually rpmbuild succeeds with this
             %files entry". Well, I don't know why (I commented on
             bug 505995 comment 3)

    Also. the %files entry
---------------------------------------------------
%dir %{_datadir}/gource/*
---------------------------------------------------
    also contains some files and this entry should also be fixed
    ( again due to a bug in rpm currently rpmbuild succeeds... )

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list