[Bug 549605] Review Request: libopenr2 - MFC/R2 call setup library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549605

--- Comment #1 from Michael Schwendt <mschwendt at gmail.com> 2010-01-11 15:03:01 EST ---
> %files
> %doc %dir doc/asterisk

Directories are never marked %doc.

> %config(noreplace) %{_sysconfdir}/openr2/r2proto.conf
> %config(noreplace) %{_sysconfdir}/openr2/r2test.conf

Which package owns %{_sysconfdir}/openr2/?

> %files devel
> %doc AUTHORS ChangeLog COPYING COPYING.LESSER NEWS README TODO

Is it really necessary to duplicate all these %doc files in this package? The
-devel package already depends on the base package anyway.

> %{_includedir}/openr2.h
> %{_includedir}/openr2/*.h

Directory %{_includedir}/openr2/ is not included.


> License:        LGPLv2
> %doc AUTHORS ChangeLog COPYING COPYING.LESSER NEWS README TODO

Interestingly, files COPYING and COPYING.LESSER contain the GPL v3 and the LGPL
v3, respectively. And many of the source files contain either a LGPLv2 or
LGPLv2+ header, so the licensing is not clear yet.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.