[Bug 548522] Review Request: autotest-client - Autotest is a framework for fully automated testing

bugzilla at redhat.com bugzilla at redhat.com
Mon Jan 11 21:13:52 UTC 2010

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


--- Comment #6 from Till Maas <opensource at till.name> 2010-01-11 16:13:49 EST ---
(In reply to comment #5)
> (In reply to comment #4)

> > Why do you set the default owner/group to autotest? It seems to be wrong, e.g.
> > /usr/share/doc/autotest-client-0.11.0/LICENSE does certainly not need to be
> > owned by autotest:autotest.
> > 
> > Also the directory structure does not seem clean, e.g. I guess
> > /usr/share/autotest/client/bin/autotest should go to /usr/bin/autotest.    
> Unfortunately, it cannot be fully packaged as you might expect new software to
> be packaged in Fedora.  Autotest is packaged upstream such that *everything*
> lives in it's own root-directory (much like other web-services like mediawiki
> or moin).  The source-code for autotest expects this.  We investigated carrying
> patches and moving content into a directory structure that was more familiar to
> most people, however that patchset would be *enormous*.

Is it really a webservice? It does not look like one. Imho for proper
packaging, at least some changes to the structure need to be made like moving
the binaries that are supposed to be called by a user /usr/bin and maybe some
stuff from tools. Or if these scripts are only supposed to be run a the
service, then they should be moved to /usr/libexec.

> I can change the default owner back to root:root, and identify the exactly
> sub-directories that autotest requires write access to if you prefer.  But it
> may not be possible to have everything root:root under /usr/share/autotest for
> autotest-client.    

Yes, please do this. But imho the directories that require write access should
also be moved below /var. But I somehow doubt, that would be enough. Why is the
autotest user even necesary? There is no init script that seems to run the
daemon with this priviliges. Is a user sopposed to su to autotest to use the

Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the package-review mailing list