[Bug 554530] Review Request: cdf - A colorized df

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=554530

Rich Mattes <richmattes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |richmattes at gmail.com

--- Comment #1 from Rich Mattes <richmattes at gmail.com> 2010-01-11 22:18:06 EST ---
I'm not an approved packager yet, so I'll give you an informal review.

-rpmlint output is clean, and should be included in the review request:
$ rpmlint cdf.spec ../RPMS/i686/cdf-*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

- No koji builds?
- spec file looks ok
- Upstream source URL works
- Upstream archive md5sum matches md5sum of source in srpm
- Builds in mock (fedora-12-i386)
- License matches source files

Comments about the program itself:
1) Program installs and runs fine, but doesn't handle long names gracefully. 
It pushes the columns out of line and line wraps, making the output
inconsistent and not so eye-friendly.  Beyond the scope of packaging, but I
thought I'd mention it.

2) It says the color scheme is customizable, but doesn't say how.  Maybe a
manpage or readme could be included to explain it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.