[Bug 552113] Review Request: libwiiuse - library to use wiiremotes via bluetooth

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=552113

--- Comment #4 from Simo Sorce <simo at fedoraproject.org> 2010-01-12 08:57:28 EST ---
(In reply to comment #3)
> The specfile url should point to libwiiuse.spec now, no?

Yes, should I change it? If so how ?

> The wiiuse website says that it's dual-licensed under GPLv3 and LGPLv3, but the spec only mentions GPLv3.

Yes the reason is that the LGPLv3 version is a modified *non-free* version
(LGPLv3 is granted only for non-commercial purposes).
So I choose to use the only free version we are allowed to use in Fedora.

> Mock build works for me (fedora-12-i386)
> 
> rpmlint output:
> $ rpmlint libwiiuse.spec ../RPMS/i686/libwiiuse-*
> libwiiuse.i686: W: unstripped-binary-or-object /usr/lib/libwiiuse.so

Doesn't rpm strip binaries on its own after building debuginfo packages?
Or do I need to actively strip them ?

> libwiiuse.i686: W: no-soname /usr/lib/libwiiuse.so
Not sure how to fix this one.

> libwiiuse.i686: W: wrong-file-end-of-line-encoding
> /usr/share/doc/libwiiuse-0.12/CHANGELOG
> libwiiuse.i686: W: wrong-file-end-of-line-encoding
> /usr/share/doc/libwiiuse-0.12/README

All the files in this library have \r\m line endings and are DOS encoded.
Should I change that ? How ?

> libwiiuse.i686: W: one-line-command-in-%post /sbin/ldconfig
> libwiiuse.i686: W: one-line-command-in-%postun /sbin/ldconfig
> libwiiuse-debuginfo.i686: E: empty-debuginfo-package

How do I fix this ?

> libwiiuse-devel.i686: W: no-documentation
> libwiiuse-examples.i686: W: unstripped-binary-or-object /usr/bin/wiiuse-example
> libwiiuse-examples.i686: W: unstripped-binary-or-object /usr/bin/wiiuse-sdl
> libwiiuse-examples.i686: W: no-documentation
> 4 packages and 1 specfiles checked; 1 errors, 10 warnings.

> The %post problems are easy to fix with
> %post -p /sbin/ldconfig
> %postun -p /sbin/ldconfig

I will fix this one.

> The wrong file-end-of-line-encoding can be fixed with dos2unix.

Do I really need to invoke dos2unix at build time to fix them ?

> The rest could be because of the build system    

Probably, I didn't use mock to build the srpm.

Let me know if there docs or howtos to read that explain the above issues and
how to fix them (rpmlint on F11 didn't complain at all)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.