[Bug 226061] Merge Review: libwvstreams

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226061

--- Comment #1 from Kamil Dudka <kdudka at redhat.com> 2010-01-12 11:07:08 EST ---
considered OK
=============
- silent rpmlint
- sane summary/description
- valid project URL and source URL
- upstream tarball is the same as the one from look-aside cache
- md5 hash matches the sources
- dist tag OK
- license tag OK
- BuildRoot tag OK
- configure options OK
- %clean OK
- %files OK
- %defattr OK
- %doc OK


may be better
=============
- duplicated BuildRequires for pkgconfig (already required by openssl-devel)
- patch wvstreams-4.5-noxplctarget.patch has no link to the upstream thread
- make LIBS_DBUS=/%{_lib}/libdbus-1.so deserves a comment
- make should either use %{?_smp_mflags} or there should be a comment why the
parallel build does not work

- -fpermissive should not appear in COPTS:
cc1: warning: command line option "-fpermissive" is valid for C++/ObjC++ but
not for C

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.