[Bug 552113] Review Request: libwiiuse - library to use wiiremotes via bluetooth

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=552113

--- Comment #6 from Simo Sorce <simo at fedoraproject.org> 2010-01-12 11:42:15 EST ---
(In reply to comment #5)
> I was just making sure that I was looking at the right files.  The licensing
> thing also makes sense.

OK

> Some comments on the spec: 
> 
> - According to http://fedoraproject.org/wiki/Packaging/Debuginfo, shared libs
> and binaries should be exectuable.  the .so and two programs should be
> installed with permission 755, and the header file can stay 644.  This clears
> up the debuginfo warning and the unstripped binary warnings.

will fix post install

> - %post -p and %postun -p do clear up the rpmlint warning 

will do

> - dos2unix fixes the line encoding.  The solution at
> https://fedoraproject.org/wiki/ParagNemade/CommonRpmlintErrors#wrong-script-end-of-line-encoding
> is to not include files like that at all in the source tarballs, i don't know
> how feasible that is.

I don't think it is very feasible, every single text file including source code
is in DOS format :(

> - The no documentation messages should be OK, you have some documentation in
> the base package.
> 
> - The no-soname error means that the library is being built without a soname. 
> One way to get around this is to add an option to the LDFLAGS in src/Makefile. 
> You can add -Wl,-soname,libwiiuse.so to give the library the soname of
> "libwiiuse.so".  Verify by using "objdump -p libwiiuse.so |grep SONAME"  

will do

> Other comments: 
> 
> - Standard build systems like autotools and cmake play nicer with rpms, but
> with some patching this one could be made to work w.r.t. install paths, soname
> generation, etc.

Yeah the quality of the build system is craptastic, but it is what it is for
now.

> - It would be nice if there was a .pc file included as it's a development
> library.    

At some point I will try to contribute something like this to upstream, for now
I guess we need to settle with what is available, as long as it is acceptable.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.