[Bug 226061] Merge Review: libwvstreams

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226061

--- Comment #2 from Ondrej Vasik <ovasik at redhat.com> 2010-01-12 12:29:06 EST ---
Thanks for review...

I would prefer to keep BuildRequires for pkgconfig - although it is almost sure
it will be required in future by openssl-devel, someone may modify the spec
file, throw away with-openssl configure option and openssl-devel requirement -
and missing dependency will appear. It is harmless as it (slightly) affects
only build speed/dependency resolving...

Patch is missing link to upstream thread as it probably was not reported, it
seems I forgot to do that. I'll do that tomorrow.

make LIBS_DBUS=/%{_lib}/libdbus-1.so commented - upstream searches for .a
library and and without hardcoding LIBS_DBUS it caused build failures.

parallel build will be used, "-fpermissive" from COPTS thrown away.

Commited to CVS, building as libwvstreams-4.6.1-2.fc13 .

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.