[Bug 518318] Review Request: vanessa_socket - Simplify TCP/IP socket operations

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518318

Garrett Holmstrom <gholms.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gholms.fedora at gmail.com

Bug 518318 depends on bug 518315, which changed state.

Bug 518315 Summary: Review Request: vanessa_logger - Generic logging layer
https://bugzilla.redhat.com/show_bug.cgi?id=518315

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|                            |ERRATA

--- Comment #7 from Garrett Holmstrom <gholms.fedora at gmail.com> 2010-01-12 23:04:55 EST ---
Here are some more comments that should be useful:

- libvanessa_socket/vanessa_socket_daemon.c is GPLv2+, not LGPLv2+, so I'm
fairly certain the license field needs to change.

- You actually do need to run autotools because the stock configure script adds
an RPATH:
vanessa_socket.x86_64: E: binary-or-shlib-defines-rpath
/usr/bin/vanessa_gethostbyname ['/usr/lib64']
vanessa_socket-pipe.x86_64: E: binary-or-shlib-defines-rpath
/usr/bin/vanessa_socket_pipe ['/usr/lib64']

- The only other complaint rpmlint has relates to a lack of %doc files in the
devel subpackage; I'm not sure how important that is here.
vanessa_socket-devel.x86_64: W: no-documentation

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.