[Bug 514068] Review Request: parti-all - Software from the Parti project

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514068

Garrett Holmstrom <gholms.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gholms.fedora at gmail.com

--- Comment #2 from Garrett Holmstrom <gholms.fedora at gmail.com> 2010-01-12 23:49:21 EST ---
I can't do an official review, so here are some unofficial comments based on
https://fedoraproject.org/wiki/Packaging/Guidelines and
https://fedoraproject.org/wiki/Packaging:Python

- In addition to the dangling symlinks you mention above, rpmlint complains
about some bad executable permissions that need to be fixed.
wimpiggy.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/wimpiggy/lowlevel/bindings.so 0775
xpra.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/xpra/wait_for_x_server.so 0775

- Documentation files should be marked as such with %doc in the spec file.

- For a Python package you should BuildRequire python-devel instead of python.

- You're missing the byte compilation step of %install specified by
https://fedoraproject.org/wiki/Packaging:Python#Byte_Compiled_Files:
%{__python} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT

I hope that helps!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.