[Bug 538820] Review Request: roboptim-core - Numerical optimization for robotics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538820

--- Comment #3 from Thomas Moulard <thomas.moulard at gmail.com> 2010-01-13 09:19:12 EST ---
Here is my new try:
Spec URL: http://homepages.laas.fr/~tmoulard/fedora/roboptim-core-0.5-1.spec
SRPM URL:
http://homepages.laas.fr/~tmoulard/fedora/roboptim-core-0.5-1.fc11.src.rpm

* SourceURL
    I stick as close as possible to the standard but unfortunately the
    package is called roboptim-core and the SF project roboptim so I cannot
    use %{name} directly.

Source0: http://downloads.sourceforge.net/roboptim/%{name}-%{version}.tar.gz

    ...seems the best I can do.

* Requires
  - I removed pkgconfig from requirements in -devel.

  - I have replace roboptim-core = %{version}-%{release}
    by
    Requires: %{name} = %{version}-%{release}

  - I have added "Requires: boost-devel, libtool-ltdl-devel" to -devel.

* pkgconfig file
  - I fixed the bug in docdir & doxygendocdir
    in build-aux/pkg-config.pc.in. Thanks for reporting!

* Non-library in %_libdir
  - I now package my plug-in ``roboptim-core-dummy-plugin'' in
    the main package (roboptim-core) and install it in ``%{_libdir}/%{name}''.
    As I am developping the package and I do not want to bother patching
    the rpm only, I re-released to fix that issue.
    Also, note that ltdl_openext do not search for versioned shared libraries
    so roboptim-core-dummy-plugin.so is required in the main package.

* Timestamps
  - spec file now use
  ``make install DESTDIR="$RPM_BUILD_ROOT" INSTALL="install -p"''

* About -doc subpackage
  - My bad, documentation subpackage has been fixed (texlive-latex,
    texlive-dvips) are required to compile the documentation properly.

I checked again the rpm with koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1918737
This time it seems everything is alright.

BTW rpmlint do not indicate any error on the rpm except no-documentation for
roboptim-core / roboptim-core-devel (which is ok since there is a documentation
subpackage).

Thanks for your time and your precious help!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.