[Bug 529496] Review Request: libmtag - An advanced C music tagging library with a simple API

bugzilla at redhat.com bugzilla at redhat.com
Wed Jan 13 16:08:14 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529496

--- Comment #43 from Felipe Contreras <felipe.contreras at gmail.com> 2010-01-13 11:08:11 EST ---
(In reply to comment #42)
> 1) Show that the C++ file is built with Fedora's global optflags.

Do you have trouble clicking links?
http://koji.fedoraproject.org/koji/getfile?taskID=1918807&name=build.log

Or do you want me to grep the CFLAGS for you?
make V=y 'CFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic' -j4

> 2) Show that the file LICENSE is included in the packages built from the
> src.rpm.

You mean the binary package? If so, will add.

> 3) Show that no file in libmtag-devel.x86_64 (and libmtag-devel.ppc64) contains
> a hardcoded /usr/lib.    

% rpm -q -l -p libmtag-0.3.4-2.fc12.x86_64.rpm
/usr/lib64/libmtag.so.0

% rpm -q -l -p libmtag-devel-0.3.4-2.fc12.x86_64.rpm 
/usr/include/libmtag
/usr/include/libmtag/mtag.h
/usr/lib64/libmtag.so
/usr/lib64/pkgconfig/libmtag.pc

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list