[Bug 225670] Merge Review: cups

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225670

--- Comment #2 from Tim Waugh <twaugh at redhat.com> 2010-01-13 12:11:30 EST ---
(In reply to comment #1)
>   - don't use /usr/lib/cups for binaries. Directory /usr/libexec/cups should be
>     used instead.

I asked upstream whether they would change the default to be /usr/libexec, and
the answer was that it was not sufficiently standard for them.  As there are
plenty of 3rd party CUPS packages, and they need to know where to put their
binaries, we deliberately stick to the upstream path for this to avoid
incompatibilities.

>   - remove unneeded versioned BuildRequires (gcc, libselinux, audit-libs, dbus)
>   - drop -fstack-protector-all gcc flag. -fstack-protector is sufficient, I
>     think. Consider to build cupsd (and other programs exposed on the network) 
>     as PIEs.

So, firstly, cupsd is already built as a position-independent executable.  That
patch was integrated upstream, and we use the --enable-pie option when calling
configure.

As for the -fstack-protector-all flag: are you sure -fstack-protector is
sufficient?  It seems to offer less security.  The versioned gcc requirement is
for -fstack-protector-all.

> 3:
>   - use %find_lang to package locale files. Check
>     https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files 
>     for more info.

Unfortunately CUPS doesn't use gettext and instead has its own mechanism for
installing language files.  It is not compatible with %find_lang.

> 4:
>   - fire away Source4 and use system wide pstopdf, please.

There is no system wide pstopdf.  Note that this is not a generic program but a
CUPS filter and must operate in a particular way (see man 7 filter).

Working on the other fixes, thanks for pointing them out.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.