[Bug 529496] Review Request: libmtag - An advanced C music tagging library with a simple API

bugzilla at redhat.com bugzilla at redhat.com
Wed Jan 13 17:30:29 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529496

--- Comment #46 from Felipe Contreras <felipe.contreras at gmail.com> 2010-01-13 12:30:24 EST ---
(In reply to comment #45)
> No, I want to you show that the C++ file is compiled with Fedora's flags.
> 
> Just do it, please. There's nothing wrong with trial-and-error packaging
> attempts.
> 
> > make V=y 'CFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
> > -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic' -j4
> 
> That's just the "make" invocation. Verify that those CFLAGS are used properly
> by the compiler invocations.

You could just say: "gcc is ok, but g++ is not using the flags"

Nah, that would be too direct. It's better to go back and forth a couple of
times without pointing out the problem.

Anyway, fixed.

> > % rpm -q -l -p libmtag-devel-0.3.4-2.fc12.x86_64.rpm 
> > /usr/include/libmtag
> > /usr/include/libmtag/mtag.h
> > /usr/lib64/libmtag.so
> > /usr/lib64/pkgconfig/libmtag.pc    
> 
> Now have a look at the contents of libmtag.pc.

Presumably that's your indirect way of pointing a problem; if that problem is a
wrong libdir, then, also fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list