[Bug 543151] Review Request: erlang-exmpp - A library for the eXtensible Messaging and Presence Protocol

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=543151

Florent Le Coz <louizatakk at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |louizatakk at fedoraproject.or
                   |                            |g

--- Comment #3 from Florent Le Coz <louizatakk at fedoraproject.org> 2010-01-13 14:25:35 EST ---
Some quick notes about your spec file :

your %files section contains many many lines, this is bad for maintenance (if
the new version has changes in its documentation for example, you'd have to
check each file one by one…)

you could do, for example :

%doc doc/stylesheet.css 
%doc doc/erlang.png
%doc doc/*.html
%{_libdir}/erlang/lib/%{realname}-%{version}

The last line says that your package owns the directory and all its content
(and sub-content), no need to specify each file

Also, you should use %global instead of %define (line 1)

Except from that, it's OK for me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.