[Bug 538820] Review Request: roboptim-core - Numerical optimization for robotics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538820

--- Comment #4 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-01-13 14:50:16 EST ---
For 0.5-1:

* Source0
  - Again Source0 in your srpm does not coincide with the tarball
    I could download from the URL written in the spec file:
-------------------------------------------------------------
500600 2010-01-13 22:46 downloaded/roboptim-core-0.5.tar.gz
500604 2010-01-13 22:46 roboptim-core-0.5-1.fc11.src/roboptim-core-0.5.tar.gz
-------------------------------------------------------------

* BR (BuildRequires)
  - For tex related dependency we prefer to use virtual Provides
    name instead of using rpm names directly.
    i.e. Please use "BR: tex(latex), tex(dvips)"

* Directory ownership issue
  - The following directories (here saying the directories themselves)
    are not owned by any packages
-------------------------------------------------------------
%{_libdir}/%{name}/
%{_datadir}/doc/%{name}-%{version}/
-------------------------------------------------------------
     Please check:
    
https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes

* Documents
  - "COPYING" or so must be in main package. Please move
    "AUTHORS COPYING THANKS README NEWS" to the main package.

  ! NOTE
    - As I said in the previous comment 2, if you write
      "%doc AUTHORS COPYING THANKS README NEWS" in the main
      package, this will firstly remove all files under
      %buildroot%_docdir/%name-%version, including installed
      doxygen html files.
      To avoid this (and to fix directory ownership issue
      written above),

      - After "make install ....." line, add
-------------------------------------------------------------
install -cpm 644 AUTHORS COPYING THANKS README NEWS \
 $RPM_BUILD_ROOT%{_docdir}/%{name}-%{version}/
-------------------------------------------------------------
      - And in %files:
-------------------------------------------------------------
%files
%defattr(-,root,root,-)
%dir %{_docdir}/%{name}-%{version}/
%{_docdir}/%{name}-%{version}/[A-Z]*
....
....
%files doc
%defattr(-,root,root,-)
%{_docdir}/%{name}-%{version}/doxygen-html/
-------------------------------------------------------------
        By the way use %{_docdir} instead of %{_datadir}/doc :
        https://fedoraproject.org/wiki/Packaging/RPMMacros

        ! Just a note
          - All files/directories/etc under /usr/share/doc are
            automatically marked as %doc.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.