[Bug 225670] Merge Review: cups

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225670

--- Comment #4 from Tim Waugh <twaugh at redhat.com> 2010-01-14 07:51:04 EST ---
Please take another look at cups-1.4.2-24.fc13.  I've added lots of fixes for
the issues raised.

As for rpmlint errors:

cups.x86_64: E: file-in-usr-marked-as-conffile
/usr/share/cups/templates/es/class-added.tmpl
[...]

All of these are for bug #441719.

cups.x86_64: E: non-readable /usr/lib/cups/backend/lpd 0700
cups.x86_64: E: non-standard-executable-perm /usr/lib/cups/backend/lpd 0700
cups.x86_64: E: non-readable /usr/lib/cups/backend/serial 0700
cups.x86_64: E: non-standard-executable-perm /usr/lib/cups/backend/serial 0700
cups.x86_64: E: non-readable /usr/lib/cups/backend/dnssd 0700
cups.x86_64: E: non-standard-executable-perm /usr/lib/cups/backend/dnssd 0700
cups.x86_64: E: non-readable /usr/lib/cups/backend/ipp 0700
cups.x86_64: E: non-standard-executable-perm /usr/lib/cups/backend/ipp 0700

All these backends must be run as root.  Backends with execute permission only
for the owner need to be run as root.  See the PERMISSIONS section of 'man 7
backend'.

cups.x86_64: E: non-readable /etc/cups/classes.conf 0600
cups.x86_64: E: zero-length /etc/cups/classes.conf
cups.x86_64: E: non-readable /etc/cups/printers.conf 0600
cups.x86_64: E: zero-length /etc/cups/printers.conf
cups.x86_64: E: non-readable /etc/cups/cupsd.conf 0640

These files may contain security-sensitive information.

cups.x86_64: E: non-readable /etc/cups/cupsd.conf.default 0640
cups.x86_64: W: non-conffile-in-etc /etc/cups/cupsd.conf.default

To have the same permissions as the cupsd.conf file it has default content for.
 Also, this is *the* default content and is not intended to be configured.
(Should it live elsewhere?)

cups.x86_64: E: zero-length /etc/cups/lpoptions
cups.x86_64: E: zero-length /etc/cups/subscriptions.conf
cups.x86_64: E: zero-length /etc/cups/client.conf

Making sure that these files exist in the manifest to ensure they are created
with the correct SELinux file contexts.

cups.x86_64: E: non-standard-dir-perm /var/run/cups/certs 0511
cups.x86_64: E: non-standard-dir-perm /etc/cups/ssl 0700
cups.x86_64: E: non-standard-dir-perm /var/spool/cups 0710
cups.x86_64: E: non-standard-dir-perm /var/spool/cups/tmp 01770

These are all correct and reflect their intended use.

cups.x86_64: W: devel-file-in-non-devel-package /usr/share/cups/ppdc/label.h
cups.x86_64: W: devel-file-in-non-devel-package /usr/share/cups/ppdc/escp.h
cups.x86_64: W: devel-file-in-non-devel-package /usr/share/cups/ppdc/pcl.h
cups.x86_64: W: devel-file-in-non-devel-package /usr/share/cups/ppdc/hp.h

These are not devel files in fact and are required at run-time by CUPS DDK
drivers (e.g. /usr/share/cups/drv/sample.drv).

cups.x86_64: E: non-readable /usr/sbin/cupsd 0500
cups.x86_64: E: non-standard-executable-perm /usr/sbin/cupsd 0500

See http://cups.org/str.php?L3459 and bug #546004.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.