[Bug 552826] Merge Review: perl-Tree-DAG_Node - Class for representing nodes in a tree

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=552826

Jan Vcelak <jvcelak at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Jan Vcelak <jvcelak at redhat.com> 2010-01-14 08:53:52 EST ---
MUST items:

[YES] rpmlint is silent:

$ rpmlint ./perl-Tree-DAG_Node.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

[YES] Package meets naming and packaging guidelines.
[YES] Spec file matches the base package name.
[YES] Meets licensing guidelines.
[YES] License specified in spec file and matches.
[YES] Spec file in American English.
[YES] Spec file is legible.
[YES] Spec file uses macros consistently.
[YES] Sources match upstream version.
[YES] Can be successfully compiled.
[YES] All BuildRequires are listed.
[YES] Doesn't bundle copies of system libraries.
[YES] Owns all it's files.
[YES] Directory ownership meets Perl packaging guidelines.
[YES] Permissions specified properly in %files.
[YES] Contains code, or permissible content.
[YES] Documentation needn't separate package.
[YES] %doc files doesn't affect runtime.
[YES] Cleans buildroot in %clean.
[YES] Cleans buildroot at the beginning of %install.
[YES] All filenames are valid UTF-8.

Other must items doesn't concern.

SHOULD items:

[YES] Builds in mock.
[YES] Builds on all supported architectures. (Package is architecture
independent.)
[YES] Sane scriptlets.

Notes:

Package doesn't contain separate file with license (only a note in README). But
as far as it is Perl module, requires Perl and is licensed under the same
license as Perl, I think it's OK.

So, ACCEPT.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.