[Bug 552898] Merge Review: perl-Authen-SASL - SASL Authentication framework for Perl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=552898

--- Comment #1 from Jan Vcelak <jvcelak at redhat.com> 2010-01-14 10:47:52 EST ---
MUST items:

[NO] rpmlint is silent:

$ rpmlint perl-Authen-SASL.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint perl-Authen-SASL-2.13-2.fc13.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint -i perl-Authen-SASL-2.13-2.fc13.noarch.rpm
perl-Authen-SASL.noarch: E: useless-provides
perl(Authen::SASL::Perl::DIGEST_MD5)
This package provides 2 times the same capacity. It should only provide it
once.

perl-Authen-SASL.noarch: E: useless-provides perl(Authen::SASL::Perl::EXTERNAL)
This package provides 2 times the same capacity. It should only provide it
once.

1 packages and 0 specfiles checked; 2 errors, 0 warnings.

[YES] Package meets naming and packaging guidelines.
[YES] Spec file matches the base package name.
[YES] Meets licensing guidelines.
[YES] License specified in spec file and matches.
[YES] Spec file in American English.
[YES] Spec file is legible.
[YES] Spec file uses macros consistently.
[YES] Sources match upstream version.
[YES] Can be successfully compiled.
[YES] All BuildRequires are listed.
[YES] Doesn't bundle copies of system libraries.
[YES] Owns all it's files.
[YES] Directory ownership meets Perl packaging guidelines.
[YES] Permissions specified properly in %files.
[YES] Contains code, or permissible content.
[YES] Documentation needn't separate package.
[YES] %doc files doesn't affect runtime.
[YES] Cleans buildroot in %clean.
[YES] Cleans buildroot at the beginning of %install.
[YES] All filenames are valid UTF-8.

Other must items doesn't concern.

SHOULD items:

[YES] Builds in mock.
[YES] Builds on all supported architectures. (Package is architecture
independent.)
[YES] Sane scriptlets.

[NO] License file included.
 - The package doesn't include license text as a separate file from upstream.
License is not mentioned anywhere except the headers in the code. There should
be at least README file with something like "licensed under the same terms as
perl itself". Please query the upstream to include it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.