[Bug 555244] Review Request: perl-Throwable - Role for classes that can be thrown

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=555244

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2010-01-15 02:48:57 EST ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1920359
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
26ea04ae48d0ac317c07bcfc0eac98e708f5df4b  Throwable-0.100090.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=11,  0 wallclock secs ( 0.04 usr  0.01 sys +  0.56 cusr  0.05
csys =  0.66 CPU)
+ Package perl-Throwable-0.100090-1.fc12.noarch =>
Provides: perl(Throwable) = 0.100090 perl(Throwable::Error) = 0.100090
Requires: perl(Moose) perl(Moose::Role) perl(Moose::Util::TypeConstraints)

+ Not a GUI application

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.