[Bug 555018] Review Request: gnac - An audio converter for GNOME (first package, seeking sponsor)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=555018

--- Comment #3 from Taylon <taylonsilva at gmail.com> 2010-01-15 10:49:04 EST ---
(In reply to comment #1)
> Only a brief look: It looks fairly well-packaged. The existence of the several
> GConf2 related scriptlet sections is evidence that either you've found them in
> the Wiki or have copied them from a package.
> 

Yes, the wiki describes well the necessity of the GConf related scriptlet. I
just followed the steps described on wiki.

> 
> > $ rpmlint gnac-0.2.1-1.fc12.src.rpm 
> > gnac.src: W: no-cleaning-of-buildroot %install
> > gnac.src: W: no-buildroot-tag
> > 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
> 
> In addition to the removal of the buildroot related stuff as discovered by
> rpmlint, you could also drop the %clean section, since in F-11 and newer there
> is a default one.
> 
Ok. I don't saw nothing about to remove the %clean section too. Maybe it should
be included on the wiki too.


> > checking for intltool >= 0.35.0...  found
> 
> This was a simple rpmbuild. "BuildRequires: intltool" is missing.
> 
> Notice that you could do full scratch-builds in Fedora's build system "koji"
> even before your packager account is approved:
> http://fedoraproject.org/wiki/PackageMaintainers/Join#Install_the_Client_Tools_.28Koji.29DK
> 
I thought I should use koji only after be approved. Now I followed the steps to
use koji and I saw the problem with inttool.

> > configure: WARNING: The 'faac' element was not found.
> > This will cause encoding to AAC to fail.
> 
> What are the implications with regard to file types which need 3rd party
> GStreamer plugins?
> 
The gnac will be unable to convert this file type. What I should to do in this
case?

> The .desktop file also defines several MIME types for file types, which are not
> directly supported by Fedora. Theoretically, it would be better to drop
> unsupported MIME types and let 3rd party add-on packages supply them together
> with the needed GStreamer plugins. E.g. in a gnac-freeworld package.
>
How can I know exactly which are the MIME types supported by Fedora?

*** The other things I understand.
Thank you for the comments

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.