[Bug 555018] Review Request: gnac - An audio converter for GNOME (first package, seeking sponsor)

bugzilla at redhat.com bugzilla at redhat.com
Fri Jan 15 17:40:56 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=555018

--- Comment #4 from Michael Schwendt <mschwendt at gmail.com> 2010-01-15 12:40:53 EST ---
[%clean]

Indeed. Rely on the guidelines and keep the %clean then.

A quick recheck with rpm-4.7.2-1.fc12 only gives me the default --clean but not
a default %clean that would remove the buildroot.


[the MIME types / unsupported file types]

"gst-inspect" prints many details for the installed GStreamer plugins. e.g.
"gst-inspect mad" prints the MIME type audio/mpeg as one of the Capabilities of
the "mad" plugin.

So far, gnac requires "gstreamer-plugins-base", but advertises support for the
following types,

$ grep Mime gnac.desktop 
MimeType=application/ogg;application/xspf+xml;audio/mpeg;audio/mp4;audio/x-flac;audio/x-mpegurl;audio/x-musepack;audio/x-scpls;audio/vnd.rn-realaudio;audio/x-speex;audio/x-wav;audio/x-wma;

whereas some of the formats clearly need 3rd party GStreamer plugins. The
question is whether to keep those defaults in the .desktop file?

If I import a .wma or .mpc file into gnac, for example, because the desktop
assumes that gnac can handle those file formats, gnac doesn't complain at
first. However, if I ask it to convert that file into .wav, it fails with an
ambiguous warning in the status bar,

   Conversion complete with errors

and prints an additional message on the console:

$ gnac
Gnac failed to convert file file:///home/qa/Desktop/audio/test/1.wma
 Error message: An error occured during conversion

No hint on what went wrong or whether additional plugins would be needed. Since
gnac package cannot depend on 3rd party GStreamer packages, it is sort of
"crippled" without the missing plugin packages but tells the desktop database
that it understands the file formats. It's a package design question.

The downside of removing unsupported file types from the .desktop file would be
that a 3rd party gnac add-on package would be needed [to provide a hidden
.desktop file that adds the additional types and to add all extra dependencies
on plugin/codec packages].

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list