[Bug 552331] Review Request: piranha - Tools for administration of Linux Virtual Server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=552331

--- Comment #7 from Milos Jakubicek <xjakub at fi.muni.cz> 2010-01-16 07:52:19 EST ---
I'm afraid there are still things to be fixed besides /etc/sysconfig:

1) you removed "shadow-utils" from Requires(pre) -- why? I explicitly wrote you
should remove them from Requires(postun) -- because we don't delete user/group
after package removal (as I wrote before), but you still need it to create
them, so the Requires(pre): shadow-utils must be preserved.

It would be indeed also most robust to use getent to check whether the given
user/group already exists -- you can just copy over the example from here:

http://fedoraproject.org/wiki/Packaging:UsersAndGroups

2) what I didn't mention in the second, only in the first post: please indeed
read the
http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control page
and accompany the specfile with instructions which make creating your sources
tarball reproducible (see the example on the page).

3)

>rpmlint ../RPMS/x86_64/piranha-0.8.5-1.fc12.x86_64.rpm
piranha.x86_64: W: incoherent-version-in-changelog 0.8.5-1.fc13
['0.8.5-1.fc12', '0.8.5-1']

=> whatever format in comments you use, please be consistent, the specfile
changelog alters the style every here and now. Note that there are only 3
possible changelog formats you can use (and this is a MUST since they are
parsed automatically by tools like packagekit):

http://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

4)

Licensing: the licese of send_arp.c is ok now, but none of the rest has been
resolved, please read again my first post which described in detail what the
problem is.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.