[Bug 555991] Review Request: compizconfig-backend-kconfig4 - Kconfig4 backend for compizconfig

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=555991

Rex Dieter <rdieter at math.unl.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |rdieter at math.unl.edu
               Flag|                            |fedora-review?

--- Comment #1 from Rex Dieter <rdieter at math.unl.edu> 2010-01-16 16:17:48 EST ---
A few quick initial comments:
1.  probably only really need
BuildRequires: kdelibs4-devel
(unverified, unless you know better)

2.  in %install, use
make install/fast DESTDIR=%{buildroot} -C %{_target_platform}
intead

3.  in %install, no need for .la file hackery.  kde4/cmake produces none.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.