[Bug 544739] Review Request: kopete-protocol-facebook - Facebook Protocol support for Kopete

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=544739

--- Comment #10 from Thomas Janssen <thomasj at fedoraproject.org> 2010-01-17 05:05:05 EST ---
OK# rpmlint must be run on every package.
[thomas at tusdell ~]$ rpmlint mock-test/kopete-protocol-facebook-0.1.5-3*
mock-test/kopete-protocol-facebook-debuginfo-0.1.5-3.fc12.x86_64.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
OK# The package must be named according to the Package Naming Guidelines .
OK# The spec file name must match the base package %{name}
OK# The package must meet the Packaging Guidelines.
OK# The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK# The License field in the package spec file must match the actual license.
OK# License file included in %doc.
OK# The spec file must be written in American English.
OK# The spec file for the package MUST be legible.
OK# md5sum 2ff70b6a35587cb80729e37628af0342
OK# The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK# Compiles on all primary archs.
OK# Build dependencies listed in BuildRequires.
OK# Packages must NOT bundle copies of system libraries.
Issue# A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.

Please add Requires: kdenetwork

OK# A Fedora package must not list a file more than once in the spec file's
%files listings.
OK# Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK# %clean section, which contains rm -rf %{buildroot}
OK# Each package must consistently use macros.
OK# The package must contain code, or permissable content.
OK# doc handling
OK# No header files existent
OK# No static libraries existent
OK# No pkgconfig(.pc) files existent
OK# No need for a -devel subpackage
OK# No .la libtool archives existent
OK# No GUI application existent, so no desktop-file-install needed.
OK# Directory ownership
OK# At the beginning of %install, each package MUST run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
OK# All filenames in rpm packages must be valid UTF-8.


-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.