[Bug 543151] Review Request: erlang-exmpp - A library for the eXtensible Messaging and Presence Protocol

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=543151

--- Comment #4 from Peter Lemenkov <lemenkov at gmail.com> 2010-01-17 05:36:18 EST ---
(In reply to comment #3)
> Some quick notes about your spec file :
> 
> your %files section contains many many lines, this is bad for maintenance (if
> the new version has changes in its documentation for example, you'd have to
> check each file one by one…)

I obviously didn't generate this list by hand - that would be quite silly :).

In fact, I believe, that such large %files sections does help maintainership,
because you know exactly which modules were added or removed at every upgrade
(which, in turn, helps quickly resolving issues with potential ABI
incompatibilities with other applications).

Although, if you're insisting in simplifying this section, then I'll do this.

> Also, you should use %global instead of %define (line 1)

Good catch, thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.