[Bug 549556] Review Request: perl-WebService-Google-Language - Perl interface to the Google AJAX Language API

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549556

Iain Arnell <iarnell at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |iarnell at gmail.com
         AssignedTo|nobody at fedoraproject.org    |iarnell at gmail.com
               Flag|                            |fedora-review+

--- Comment #1 from Iain Arnell <iarnell at gmail.com> 2010-01-17 07:26:00 EST ---
+ source files match upstream.  
  4b7697b79880c574d9e6b9d326d4632e  WebService-Google-Language-0.10.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
  GPL+ or Artistic

+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
- BuildRequires are proper.
  missing perl(Test::Pod) and perl(Test::Pod::Coverage)

+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1927999

+ package installs properly.
+ rpmlint has no complaints:
  perl-WebService-Google-Language.noarch: I: checking
  perl-WebService-Google-Language.src: I: checking
  2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ final provides and requires are sane:
  perl(WebService::Google::Language) = 0.10
  perl(WebService::Google::Language::Result)  
  perl-WebService-Google-Language = 0.10-1.fc13
=
  perl >= 0:5.006
  perl(:MODULE_COMPAT_5.10.1)  
  perl(Carp)  
  perl(JSON) >= 2.0
  perl(LWP::UserAgent)  
  perl(URI)  
  perl(constant)  
  perl(strict)  
  perl(warnings)  
  rpmlib(CompressedFileNames) <= 3.0.4-1
  rpmlib(FileDigests) <= 4.6.0-1
  rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  rpmlib(VersionedDependencies) <= 3.0.3-1
  rpmlib(PayloadIsXz) <= 5.2-1

+ %check is present and all tests pass.
  pod and pod-coverage tests are skipped, but otherwise,
  All tests successful.
  Files=6, Tests=45,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.39 cusr  0.04
csys =  0.47 CPU)
  Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.


I think you should add BuildRequires for perl(Test::Pod) and
perl(Test::Pod::Coverage) to complete the test suite. 

APPROVED.

(and if you're in a review swapping mood, bug #532190 should be another easy
one)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.