[Bug 555160] Review Request: picosat - A SAT solver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=555160

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #1 from Martin Gieseking <martin.gieseking at uos.de> 2010-01-17 14:37:24 EST ---
Just some quick comments:

- you can drop gzip from Requires because it's picked up automatically

- the file permissions of the binaries should be changed to 755, e.g. by
replacing cp with install:
  install -p -m 0755 libpicosat.so
$RPM_BUILD_ROOT%{_libdir}/libpicosat.so.0.0.%{version}

  install -p -m 0755 picosat $RPM_BUILD_ROOT%{_bindir}


$ rpmlint /var/lib/mock/fedora-12-x86_64/result/picosat-*
picosat.x86_64: W: no-documentation
picosat.x86_64: E: non-standard-executable-perm /usr/bin/picosat 0775
picosat-devel.x86_64: W: no-documentation
picosat-libs.x86_64: E: non-standard-executable-perm
/usr/lib64/libpicosat.so.0.0.913 0775
5 packages and 0 specfiles checked; 2 errors, 2 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.