[Bug 556346] Review Request: stage - A 2.5D multi-robot simulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=556346

--- Comment #3 from Jussi Lehtola <jussi.lehtola at iki.fi> 2010-01-18 02:57:54 EST ---
A few comments:

- IMHO there's no sense in using macros for patch names. Normally you can use
the same patch for a bunch of minor releases; name the patch after the version
you wrote it against.

- Source URL doesn't accord to guidelines, mesh.dl. should be downloads.

- Drop the explicit Requires: fltk. It should be automatically picked up by
rpm.

- I doubt -devel really needs cmake. Drop the requirement.

- Isn't SMP make working? If not, make a comment. Using "make -j1" is silly,
why not use just plain "make"?

- Please make %files section more explicit.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.