[Bug 555941] Review Request: eclipse-manpage - Man page viewer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=555941

--- Comment #2 from Mat Booth <fedora at matbooth.co.uk> 2010-01-18 05:37:58 EST ---
Sorry for the delay, eventful weekend...


Nitpick 1:

SPEC file must be in American English: There's a tiny grammatical error in the
package description; there should be no apostrophe in the possessive form of
"it".

Nitpick 2:

I know it isn't the case for this package, but I think it's good practice to
check for class files and jars in the source for Java packages, as per the Java
package template [1] or the bit of script from the Eclipse plug-in guidelines.
[2]

Nitpick 3:

Please use %global instead of %defined. [3] If these lines were generated by
RPMStubby, we should probably file a bug there too.


If you are happy to address these three things, then I say this package is
APPROVED.


[1] http://fedoraproject.org/wiki/Packaging:Java#ant
[2] http://fedoraproject.org/wiki/Packaging:EclipsePlugins#Pre-built_binaries
[3]
http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.