[Bug 548522] Review Request: autotest-client - Autotest is a framework for fully automated testing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=548522

--- Comment #9 from James Laska <jlaska at redhat.com> 2010-01-18 08:19:38 EST ---
(In reply to comment #8)
> James, at least the "/usr as read-only" principle is one it's really worth
> observing; some people actually do mount /usr over a network as read-only, and
> will complain vociferously if something expects to be able to write to it. I'm
> sort of with Till here, really; autotest does seem to be wilfully doing rather
> odd things, and I think it'd be perfectly reasonable to patch those even if
> upstream weren't immediately interested in the patch. It's not a question of 'a
> downstream distribution's' filesystem standards, this is FHS stuff, which all
> distros pay at least lip service to.

Yeah, it certainly would be cleaner to have it more in line with what most
Fedora packages look like.  Unfortunately, that's a pretty aggressive and
*unmaintainable* patch.  Also, while it's a *SHOULD* have, it's not a *MUST*
have in the packaging guidelines.

    "Fedora follows the Filesystem Hierarchy Standard with regards to
    filesystem layout. The FHS defines where files should be placed on the
    system.  Fedora packages must follow the FHS. Any deviation from the FHS
    should be rationalized when the package is reviewed. " 

    - https://fedoraproject.org/wiki/Packaging/Guidelines#Filesystem_Layout

That said, in my previous comment I noted that I am attempting to address some
of the concerns around permssions.  I've not yet completed that work, and will
respond with updated packages at that time.

> You didn't seem to answer Till's question as to why an autotest user account is
> necessary.

It's a test harness that includes a local test scheduler.  I believe upstream
may run the harness as the root user.  I think that could be improved, so I've
added an 'autotest' user/group account to this package.  This comes into play
when running the harness on the local system for processing local jobs.  It
also is important when running in a distributed setup (provided by the future
autotest package).

> The comment "This package is specific to Fedora..." is probably supposed to
> read "This patch is specific to Fedora..."

Thanks, I'll addressed in the latest .spec file.

> The description is quite thin. It might be useful to explain briefly what the
> hell autotest is.

I thought it did that :)  But, I've expanded on it in the latest .spec file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.