[Bug 555160] Review Request: picosat - A SAT solver

bugzilla at redhat.com bugzilla at redhat.com
Mon Jan 18 19:05:19 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=555160

--- Comment #3 from Jerry James <loganjerry at gmail.com> 2010-01-18 14:05:16 EST ---
I dropped the gzip Requires and rebuilt.  The automatic Requires generator did
NOT pick it up.  I am building on an F-12 system.  Are either of you SURE that
you saw gzip identified as a Requires by rpmbuild?

I don't know how the Requires generator could possibly find this anyway, since
the dependency on gzip is hidden in C code (see app.c).

Regarding comment 1, Martin what is your default umask?  (Mine is 0022.)  I get
the correct permissions when building on my machine, in mock, and with a koji
scratch build.  David Wheeler also reports getting correct permissions in
comment 2.  This makes me suspect that the problem is with your environment,
rather than with the package.  In any case, koji-built packages will have
correct permissions with the spec file as-is.  (Not that I object to using
install instead of cp; I'll make that change anyway if I have to make a new
package.)

The license file is in the correct place.  The -libs package is always
installed, no matter what, but the so-called "base" package is optional. 
Therefore, we need the license file where it will always be installed: the
-libs package.

I considered adding http://fmv.jku.at/papers/Biere-JSAT08.pdf as documentation,
but I'm not sure it would really help.  It talks about internal optimizations,
rather than external interfaces.  I'm not competent to write documentation on
the external interface anyway, since I don't understand it.  I only want this
so I can get a functioning csisat, which I also don't understand, since I only
want it to get a functioning blast. :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list