[Bug 556611] Review Request: ptpd - Precision Time Protocol daemon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=556611

Terje Røsten <terjeros at phys.ntnu.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |terjeros at phys.ntnu.no

--- Comment #1 from Terje Røsten <terjeros at phys.ntnu.no> 2010-01-19 04:00:10 EST ---
# is reaaly date and git tag needed?

%define date    20100118

# is such a long tag needed? 
%define snapshot git599b03bfd1294

Summary: Precision Time Protocol daemon
Name: ptpd
Version: 1.0.0
# is the snaphost pre or post 1.0.0? If pre release should start with 0.
Release: 1.%{date}%{snapshot}%{?dist}
License: ISC
Group: System Environment/Daemons
URL: git://git.infradead.org/ptpd.git

# You must add a comment on how you created the tarball.
Source0: ptpd-%{version}-%{date}%{snapshot}.tar.gz
Source1: ptpd.init
Source2: ptpd.sysconfig

Requires(post): /sbin/chkconfig
Requires(preun): /sbin/chkconfig /sbin/service
Requires(postun): /sbin/service
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)


%description

This is the the PTP daemon (PTPd). PTPd implements the Precision
Time Protocol (PTP) as defined by 'IEEE Std 1588-2002'. PTP provides
precise time coordination of Ethernet LAN connected computers.
It was designed primarily for instrumentation and control systems.


%prep 
%setup -q -n %{name}-%{version}-%{date}%{snapshot}


%build
cd src
make %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS"


%install
# binaries
# why not use shorter:

install -D -pm 0755 src/ptpd %{buildroot}%{_sbindir}/ptpd

install -d %{buildroot}/%{_sbindir}
install -pm 0755 src/ptpd %{buildroot}%{_sbindir}/ptpd

# man pages
# dont compress, rpm do that itself (and might switch to xz)
# install -pm 0664 src/ptpd.8 %{buildroot}%{_mandir}/man8/ptpd.8
# is enough
/usr/bin/gzip -c src/ptpd.8 > src/ptpd.8.gz
install -d %{buildroot}%{_mandir}/man8
install -pm 0644 src/ptpd.8.gz %{buildroot}%{_mandir}/man8

# init scripts
# use the -D trick here too,
install -d %{buildroot}/%{_initddir}
install -pm 0755 %{SOURCE1} %{buildroot}/%{_initddir}/ptpd

# config files
# ditto
install -d %{buildroot}/%{_sysconfdir}/sysconfig
install -pm 0644 %{SOURCE2} %{buildroot}/%{_sysconfdir}/sysconfig/ptpd


%clean
rm -rf $RPM_BUILD_ROOT


%files
%defattr(-,root,root,-)
%doc COPYRIGHT README RELEASE_NOTES
%doc doc/ptpd_2005_1588_conference_paper.pdf
%config(noreplace) %{_sysconfdir}/sysconfig/ptpd
%{_sbindir}/ptpd
%{_initddir}/ptpd
# use %{_mandir}/man8/ptpd.8*
%{_mandir}/man8/*


And why is #495105 restriced? For a review this don't make sense.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.