[Bug 556611] Review Request: ptpd - Precision Time Protocol daemon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=556611

Terje Røsten <terjeros at phys.ntnu.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(terjeros at phys.ntn |
                   |u.no)                       |

--- Comment #7 from Terje Røsten <terjeros at phys.ntnu.no> 2010-01-19 12:55:21 EST ---
> 
> The code does not correspond with any "official" release. The date and git tag
> are there in an attempt to comply with the packaging guidelines for snapshots.
> 
> http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages
> 
> # is such a long tag needed?
> 
> "use an %{alphatag} beginning with the date in YYYYMMDD format and followed by
> up to 16 (ASCII) alphanumeric characters of your choosing" -- is there some
> reason that this format/length is unacceptable?  Given that (however unlikely)
> the very next git commit could be 599b03bfd1295 I would prefer not to shorten
> it.

I am unsure, imho 1.%{date}git%{commitid}%{?dist} is ugly.

Might be that 1.%{date}git%{?dist} is enough.
Of course the commitid must be in the spec, however maybe not in the release
tag?


> # Where is the source coming from?
> From the URL I specified, of course.
> 
> # Is git.infradead.org a fork of the fork? Please explain.
> "Fork of the fork"?  I'm not sure I understand your question.
> 
> The original ptpd author/maintainer disappeared somewhat abruptly from the
> project.  Intel has a major interest in the project continuing, but a lack of
> interest in maintaining it themselves.  So I was recruited to shepherd the
> project, and I established the Infradead repository and mailing list for it and
> accepted some Intel-authored patches (http://github.com/pohly/ptpd) on top of
> the original 1.0.0 release.  Does that answer your question?


I ask because a google search on ptpd brings me here:

 http://ptpd.sourceforge.net/

Original author here seems to be  Kendall Correll and Aidan Williams

Then I found this:

  http://github.com/pohly/ptpd

which says:

Precision Time Protocol - temporary fork with support for hardware timestamping

http://sourceforge.net/forum/forum.php?thread_id=1781065&forum_id=469207

A guy called Patrick Ohly is doing a fork and now you have your own fork
on git.infradead.org?

Ok.

Package is good shape, some pedantic things:

 o mixing %{}- and $-style macros, change $RPM_OPT_FLAGS to %{optflags}

 o why is release starting with 1, it should start with 3 by now?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.