[Bug 556628] Review Request: Pymilia - Python wrappers for milia

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=556628

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tomspur at fedoraproject.org
         AssignedTo|nobody at fedoraproject.org    |tomspur at fedoraproject.org
               Flag|                            |fedora-review?

--- Comment #2 from Thomas Spura <tomspur at fedoraproject.org> 2010-01-19 23:10:15 EST ---
First same here, like in your milia package:

Sources do not match upstream (diff -r is empty), so what happend here?
1f9d6d2d4de2f14a90aa5762b5f67156  your sources
3b9d7aa9e4033ee945b879e9aee0525c  upstream url


Review:

Good:
- name ok
- license ok
- %clean there
- %install the python way
- %doc ok
- permissions ok
- no static libs
- rpmlint clean
- macros everywhere


TODO:
- changelog format:
  add a '- ' to the last line
- Are BR ok?
  This is a wrapper for milia so why shouldn't milia-devel >= %{version} be
needed?
  It would be the sane way ;)
  python-setuptools is missing.


Waiting for the sources comment, till I'll approve this (There are no other
blocker, not to do so...).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.