[Bug 555948] Review Request: ghc-regex-base - Haskell regex base library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=555948

Rakesh Pandit <rpandit at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |rpandit at redhat.com
               Flag|                            |fedora-review+

--- Comment #2 from Rakesh Pandit <rpandit at redhat.com> 2010-01-19 23:59:41 EST ---
[x] Build - http://koji.fedoraproject.org/koji/taskinfo?taskID=1933123 fine
[x] rpmlint - ok 

===========================================================================
Koji build rpm
/tmp/gachJJdhks/kojiXRxS3E/1933124/ghc-regex-base-0.93.1-2.fc13.src.rpm output:
===========================================================================

Rpmlint Messages:
ghc-regex-base.src: W: macro-in-%description %ghc_lib_package
ghc-regex-base.src: W: strange-permission regex-base-0.93.1.tar.gz 0600
ghc-regex-base.src: W: no-cleaning-of-buildroot %install
ghc-regex-base.src: W: no-buildroot-tag
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

Ignored.

===========================================================================
Koji build rpm
/tmp/gachJJdhks/kojiXRxS3E/1933124/ghc-regex-base-prof-0.93.1-2.fc13.x86_64.rpm
output:
===========================================================================

Rpmlint Messages:
ghc-regex-base-prof.x86_64: E: devel-dependency ghc-regex-base-devel
ghc-regex-base-prof.x86_64: W: no-documentation
ghc-regex-base-prof.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/ghc-6.12.1/regex-base-0.93.1/libHSregex-base-0.93.1_p.a
1 packages and 0 specfiles checked; 1 errors, 2 warnings.

Ignored.

===========================================================================
Koji build rpm
/tmp/gachJJdhks/kojiXRxS3E/1933124/ghc-regex-base-0.93.1-2.fc13.x86_64.rpm
output:
===========================================================================

Rpmlint Messages:
ghc-regex-base.x86_64: W: incoherent-version-in-changelog 0.93.1-1
['0.93.1-2.fc13', '0.93.1-2']
ghc-regex-base.x86_64: W: unstripped-binary-or-object
/usr/lib64/ghc-6.12.1/regex-base-0.93.1/libHSregex-base-0.93.1-ghc6.12.1.so
ghc-regex-base.x86_64: W: executable-stack
/usr/lib64/ghc-6.12.1/regex-base-0.93.1/libHSregex-base-0.93.1-ghc6.12.1.so
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

Ignored.

===========================================================================
Koji build rpm
/tmp/gachJJdhks/kojiXRxS3E/1933124/ghc-regex-base-doc-0.93.1-2.fc13.x86_64.rpm
output:
===========================================================================

Rpmlint Messages:
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Clean.

===========================================================================
Koji build rpm
/tmp/gachJJdhks/kojiXRxS3E/1933124/ghc-regex-base-devel-0.93.1-2.fc13.x86_64.rpm
output:
===========================================================================

Rpmlint Messages:
ghc-regex-base-devel.x86_64: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Ignored.


[x] name fine
[x] URL fine
[x] source ok

from srpm (sha1sum)

[rakesh at simu ~]$ sha1sum regex-base-0.93.1.tar.gz 
e94c4c15fd3f4b375eb854ee0b77787a03fc8a2c  regex-base-0.93.1.tar.gz

[rakesh at simu ~]$ sha1sum rpmbuild/SOURCES/regex-base-0.93.1.tar.gz 
e94c4c15fd3f4b375eb854ee0b77787a03fc8a2c 
rpmbuild/SOURCES/regex-base-0.93.1.tar.gz

[x] spec name fine
[x] license ok (copy present) and source has marking
[x] source tree ok (no binaries present)
[x] archs - fine
[x] spec file legible and in american english
[x] BR's ok
[x] %files ok
[x] folders owned - ok

main

/usr/lib/ghc-6.12.1/regex-base-0.93.1
/usr/share/doc/ghc-regex-base-0.93.1

doc

/usr/share/doc/ghc/html/libraries/regex-base-0.93.1

devel

/usr/lib/ghc-6.12.1/regex-base-0.93.1
/usr/lib/ghc-6.12.1/regex-base-0.93.1/Text
/usr/lib/ghc-6.12.1/regex-base-0.93.1/Text/Regex
/usr/lib/ghc-6.12.1/regex-base-0.93.1/Text/Regex/Base

[x] source builds fine on fedora ghc archs
[x] no bundled dependencies
[x] %clean section ok
[x] filenames - ok (valid)
[x] profiling ok
[x] lib goes to %{_libdir}/ghc-%{ghc_version}/%{pkg_name}-%{version}
[x] new macros

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.