[Bug 556727] Review Request: ghc-regex-compat - Haskell regex library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=556727

--- Comment #1 from Rakesh Pandit <rpandit at redhat.com> 2010-01-20 01:03:26 EST ---
[-] Build - not done - need ghc-regex-base & ghc-regex-posix imported - but
tested on two of primary arch machines i686 and x86_64 using approved
ghc-regex-base & ghc-regex-posix rpm

sudo yum -y --nogpgcheck localinstall
../RPMS/i686/ghc-regex-posix-devel-0.94.1-2.fc13.i686.rpm
../RPMS/i686/ghc-regex-posix-doc-0.94.1-2.fc13.i686.rpm
../RPMS/i686/ghc-regex-posix-prof-0.94.1-2.fc13.i686.rpm
../RPMS/i686/ghc-regex-posix-0.94.1-2.fc13.i686.rpm

[x] rpmlint - ok 

[rakesh at dhcp1-96 SPECS]$ rpmlint
/home/rakesh/rpmbuild/SRPMS/ghc-regex-compat-0.92-2.fc13.src.rpm
ghc-regex-compat.src: W: spelling-error-in-summary en_US Haskell
ghc-regex-compat.src: W: spelling-error-in-description en_US posix
ghc-regex-compat.src: W: no-cleaning-of-buildroot %install
ghc-regex-compat.src: W: no-buildroot-tag
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

Ignored.

[rakesh at dhcp1-96 SPECS]$ rpmlint
/home/rakesh/rpmbuild/RPMS/i686/ghc-regex-compat-0.92-2.fc13.i686.rpm
ghc-regex-compat.i686: W: spelling-error-in-summary en_US Haskell
ghc-regex-compat.i686: W: spelling-error-in-description en_US posix
ghc-regex-compat.i686: W: unstripped-binary-or-object
/usr/lib/ghc-6.12.1/regex-compat-0.92/libHSregex-compat-0.92-ghc6.12.1.so
ghc-regex-compat.i686: W: executable-stack
/usr/lib/ghc-6.12.1/regex-compat-0.92/libHSregex-compat-0.92-ghc6.12.1.so
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

Ignored.

[rakesh at dhcp1-96 SPECS]$ rpmlint
/home/rakesh/rpmbuild/RPMS/i686/ghc-regex-compat-devel-0.92-2.fc13.i686.rpm
ghc-regex-compat-devel.i686: W: spelling-error-in-summary en_US Haskell
ghc-regex-compat-devel.i686: W: spelling-error-in-description en_US posix
ghc-regex-compat-devel.i686: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

Ignored.

[rakesh at dhcp1-96 SPECS]$ rpmlint 
/home/rakesh/rpmbuild/RPMS/i686/ghc-regex-compat-doc-0.92-2.fc13.i686.rpm
ghc-regex-compat-doc.i686: W: spelling-error-in-summary en_US Haskell
ghc-regex-compat-doc.i686: W: spelling-error-in-description en_US posix
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Ignored.

[rakesh at dhcp1-96 SPECS]$ rpmlint
/home/rakesh/rpmbuild/RPMS/i686/ghc-regex-compat-prof-0.92-2.fc13.i686.rpm
ghc-regex-compat-prof.i686: E: devel-dependency ghc-regex-compat-devel
ghc-regex-compat-prof.i686: W: spelling-error-in-summary en_US Haskell
ghc-regex-compat-prof.i686: W: spelling-error-in-description en_US posix
ghc-regex-compat-prof.i686: W: no-documentation
ghc-regex-compat-prof.i686: W: devel-file-in-non-devel-package
/usr/lib/ghc-6.12.1/regex-compat-0.92/libHSregex-compat-0.92_p.a
1 packages and 0 specfiles checked; 1 errors, 4 warnings.

Ignored.

[x] name fine
[x] URL fine
[x] source ok

from srpm (sha1sum)



[x] spec name fine
[x] license ok (copy present) and source has marking
[x] source tree ok (no binaries present)
[x] archs - fine
[x] spec file legible and in american english
[x] BR's ok
[x] %files ok
[x] folders owned - ok

main

/usr/lib/ghc-6.12.1/regex-compat-0.92
/usr/share/doc/ghc-regex-compat-0.92

devel

/usr/lib/ghc-6.12.1/regex-compat-0.92
/usr/lib/ghc-6.12.1/regex-compat-0.92/Text

doc

/usr/share/doc/ghc/html/libraries/regex-compat-0.92

[x] source builds fine on fedora ghc archs
[x] no bundled dependencies
[x] %clean section ok
[x] filenames - ok (valid)
[x] profiling ok
[x] lib goes to %{_libdir}/ghc-%{ghc_version}/%{pkg_name}-%{version}
[x] new macros

APPROVED

Do import both base and posix packages before importing this one.

Thanks,

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.