[Bug 556628] Review Request: Pymilia - Python wrappers for milia

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=556628

--- Comment #7 from Thomas Spura <tomspur at fedoraproject.org> 2010-01-20 07:21:13 EST ---
- Please add the CFLAGS as in the template.
  But because you use %{buildroot}, use %{optflags} instead $RPM_OPT_FLAGS.

https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS
  (Thanks Jussi.)

- Add BR: python-devel again, please.
  Why is it required by milia-devel?
  Didn't you make two packages to avoid milia-devel requires python*?

  Another reason for adding this would be to not interfer with python3*.

Provides: libmilia.so.3()(64bit)
Requires(interp): /sbin/ldconfig /sbin/ldconfig
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <=
4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Requires(post): /sbin/ldconfig
Requires(postun): /sbin/ldconfig
Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit)
libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgsl.so.0()(64bit)
libgslcblas.so.0()(64bit) libm.so.6()(64bit) libm.so.6(GLIBC_2.2.5)(64bit)
libmilia.so.3()(64bit) libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit)
libstdc++.so.6(GLIBCXX_3.4.9)(64bit) rtld(GNU_HASH)
Processing files: milia-devel-0.3.0-1.fc12.x86_64
Provides: pkgconfig(milia) = 0.3.0
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <=
4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies)
<= 3.0.3-1
Requires: /usr/bin/pkg-config libmilia.so.3()(64bit) pkgconfig(gsl)


Don't see a python* here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.