[Bug 557169] Review Request: bristol - Synthesizer emulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=557169

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomspur at fedoraproject.org

--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org> 2010-01-20 17:43:28 EST ---
Just a few comments for now:

- no parallel make
  https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
- does not build for me, because of a rpath issue.
  https://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath

  Works with:
  %configure
  sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g'
libtool
  sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool

- Why do you use ./configure and not %configure?
  * /usr hardcoded -> use %{_prefix}
  * no $RPM_OPT_FLAGS (would also be in %configure)

- Why are the shared libs in -libs and no -devel package?

- When starting, there was a crash...
  (Couldn't get a backtrace, ABRT seems to hang a bit.)

- Desktop file?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.