[Bug 553769] Review Request: euca2ools - Tools for Eucalyptus EC2-compatible Computation Service

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=553769

Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #5 from Jason Tibbitts <tibbs at math.uh.edu> 2010-01-20 22:30:13 EST ---
You're right that rpmlint doesn't like modern packaging style; unfortunately
the rpmlint maintainer won't remove the warning at this time, and some
additional work is needed to support per-distribution warning configurations. 
It's certainly not a blocker to leave those things in there, but it would
certainly be foolish to add them just because rpmlint has pointless complaints.

One terribly minor thing that I'll just point out in case you're not aware:
%{buildroot} includes a trailing slash.  It makes no difference, but if you
wonder where the double slash in
  + mkdir -p /builddir/build/BUILDROOT/euca2ools-1.1-4.fc13.x86_64//usr/bin
comes from, that's it.

All of the issues I found have been fixed, and this package seems to be fine.

APPROVED

I've clicked the necessary buttons to get your packager status set up, so after
that propagates (about an hour) you should be able to make a CVS request.  If
you need any assistance getting things checked in and built, or if you'd like
for me to look over any package reviews you're doing, just ping me on IRC or
send email.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.