[Bug 557366] New: Review Request: <Google-Go> - <A new systems programming language from Google>

bugzilla at redhat.com bugzilla at redhat.com
Thu Jan 21 07:56:52 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: <Google-Go> - <A new systems programming language from Google>

https://bugzilla.redhat.com/show_bug.cgi?id=557366

           Summary: Review Request: <Google-Go> - <A new systems
                    programming language from Google>
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: nobody at fedoraproject.org
        ReportedBy: alex.combas at gmail.com
         QAContact: extras-qa at fedoraproject.org
                CC: notting at redhat.com, fedora-package-review at redhat.com
   Estimated Hours: 0.0
    Classification: Fedora


Spec URL: http://dl.dropbox.com/u/4165082/google-go-0.3.spec
SRPM URL: http://dl.dropbox.com/u/4165082/google-go-20100120-0.3.src.rpm
Description: 

This is my first package. I am seeking a sponsor.

Google Go is aimed at producing a language which compiles quickly, 
has fast execution time, and comes with built in concurrency support.

This is a devel-snapshot of the plan9 style compilers for Go.

The developers have created a rather elegant build system for Go, however
shaping it into the FHS has taken a bit of work. So when deciding where to
place the files in light of the FHS I tried to use gcc as my guide as much as
possible.

RPMLINT ERRORS :25

Errors are because of the following reasons:

1. Statically linked binarys: The reason for this is that Go is incapable of
generating dynamically linked binary at the moment, so all Go binary will be
static.

2. Files which end in .go are Go source code, and do not require shebang. 

3. Python scripts starting with "#!/usr/bin/env python" this is on purpose.

4. ~place-holder~ is not a backup file.

5. Go.plist is not a shell script, and does not require shebang.

WARNINGS: 833 

The warnings are almost all because of the presense of "devel" files.

Google-Go is a devel package, it doesn't really make sense to create two
packages when both would be required for Go development, so I have made them as
a single package.

RPMLINT ERROR OUTPUT:

google-go.x86_64: E: statically-linked-binary
/usr/lib64/google-go/20100120/src/cmd/hgpatch/hgpatch
google-go.x86_64: E: statically-linked-binary /usr/bin/gofmt
google-go.x86_64: E: statically-linked-binary
/usr/lib64/google-go/20100120/src/cmd/ebnflint/ebnflint
google-go.x86_64: E: statically-linked-binary
/usr/lib64/google-go/20100120/src/cmd/godoc/godoc
google-go.x86_64: E: statically-linked-binary /usr/bin/godoc
google-go.x86_64: E: statically-linked-binary
/usr/lib64/google-go/20100120/src/cmd/gofmt/gofmt
google-go.x86_64: E: statically-linked-binary
/usr/lib64/google-go/20100120/src/cmd/cgo/cgo
google-go.x86_64: E: statically-linked-binary /usr/bin/ebnflint
google-go.x86_64: E: statically-linked-binary /usr/bin/cgo
google-go.x86_64: E: statically-linked-binary
/usr/lib64/google-go/20100120/src/cmd/goyacc/goyacc
google-go.x86_64: E: statically-linked-binary /usr/bin/goyacc
google-go.x86_64: E: statically-linked-binary /usr/bin/hgpatch
google-go.x86_64: E: missing-PT_GNU_STACK-section
/usr/lib64/google-go/20100120/src/pkg/debug/elf/testdata/gcc-386-freebsd-exec
google-go.x86_64: E: standard-dir-owned-by-package /usr/bin
google-go.x86_64: E: non-executable-script
/usr/lib64/google-go/20100120/src/pkg/syscall/mksysnum_nacl.sh 0644
/usr/bin/perl
google-go.x86_64: E: script-without-shebang
/usr/lib64/google-go/20100120/test/hashmap.go
google-go.x86_64: E: non-executable-script
/usr/share/google-go/20100120/dashboard/builder.sh 0644 /bin/sh
google-go.x86_64: E: non-executable-script
/usr/lib64/google-go/20100120/lib/codereview/codereview.py 0644 /usr/bin/env
google-go.x86_64: E: backup-file-in-package
/usr/lib64/google-go/20100120/pkg/~place-holder~
google-go.x86_64: E: script-without-shebang
/usr/lib64/google-go/20100120/src/cmd/godoc/snippet.go
google-go.x86_64: E: non-executable-script
/usr/share/google-go/20100120/dashboard/buildcontrol.py 0644 /usr/bin/env
google-go.x86_64: E: non-executable-script
/usr/lib64/google-go/20100120/src/cmd/clean.bash 0644 /usr/bin/env
google-go.x86_64: E: non-executable-script
/usr/lib64/google-go/20100120/src/pkg/xgb/go_client.py 0644 /usr/bin/env
google-go.x86_64: E: zero-length
/usr/lib64/google-go/20100120/src/pkg/runtime/nacl/signals.h
google-go.x86_64: E: script-without-shebang
/usr/share/google-go/20100120/bbedit/Go.plist

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list