[Bug 557948] Review Request: PyAIML - A Python AIML Interpreter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=557948

Eric Smith <eric at brouhaha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric at brouhaha.com

--- Comment #1 from Eric Smith <eric at brouhaha.com> 2010-01-23 21:41:04 EST ---
I'm not yet sponsored as a packager, but here's an unofficial review:

rpmlint output:
1 packages and 1 specfiles checked; 0 errors, 0 warnings.

source tarball verified against upstream
compiles and builds on F12 x86_64 and i386 using mock
verified that upstream is public domain, so no license text file needed

When I try to verify the functionality of the package using the example in the
README.txt, and get to the point of doing 'k.respond("load aiml b")', I get
'WARNING: No match found for input: load aiml b'.  I don't really know anything
about AIML so I'm not certain what is going wrong, but it doesn't match the
expected behaviour.

I'm not sure about this one, but none of the examples in the Packaging:Python 
guidelines include the whole sitelib directory, so rather than having the files
section contain %{python_sitelib}/*, perhaps it might be better to have:
%{python_sitelib}/%{name}-%{version}-*.egg-info
%{python_sitelib}/aiml/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.