[Bug 554464] Review Request: python-pebl - Python Environment for Bayesian Learning
bugzilla at redhat.com
bugzilla at redhat.com
Sun Jan 24 03:41:55 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=554464
Thomas Spura <tomspur at fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |tomspur at fedoraproject.org
AssignedTo|nobody at fedoraproject.org |tomspur at fedoraproject.org
Flag| |fedora-review?
--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org> 2010-01-23 22:41:50 EST ---
Review:
Good:
- name ok
- license ok
- no static libs
- no *.la
Needswork:
- Requires: python
This is added automatically, please delete that.
- There is no python-setuptools-devel any more, please use python-setuptools.
- Please be a bit more explicit in %files to notice, when the egg can't be
build:
e.g.:
%{python_sitearch}/pebl/
%{python_sitearch}/pebl-*.egg-info
- %check is missing:
%{__python} setup.py test
This is currently failing. Maybe you can talk to upstream about this too.
- shipping the testsuite doesn't make sense, please delete that.
(Maybe %exclude %{python_sitearch}/pebl/test* in %files)
- Missing Requires: numpy, pydot, boto, matplotlib
What is ipython1.kernel.api? (file src/pebl/taskcontroller/ec2ipy1.py)
(I hope that's it, please double check.)
- Does it make sense to split the docs into a -docs subpackage?
The documentation is 6 times bigger than, the main package.
Maybe a point of view, but I would like that ;) (->SHOULD, no blocker)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list