[Bug 544660] Review Request: php-channel-swift - Adds swift mailer project channel to PEAR

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=544660

--- Comment #4 from Remi Collet <fedora at famillecollet.com> 2010-01-24 02:38:43 EST ---
REVIEW
* no source files (channel.xml match latest upstream)
* package meets naming 
:( package must meet packaging guidelines
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license (of the packages provided by the
channel).
* license is open source-compatible (LGPLv3).
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide).
* package installs properly
* rpmlint (warnings are ok) :
php-channel-swift.src: I: checking
php-channel-swift.src:22: W: unversioned-explicit-provides
php-channel(pear.swiftmailer.org)
php-channel-swift.noarch: I: checking
php-channel-swift.noarch: W: no-documentation
php-channel-swift.spec:22: W: unversioned-explicit-provides
php-channel(pear.swiftmailer.org)
2 packages and 1 specfiles checked; 0 errors, 3 warnings.
* final provides are sane:
php-channel(pear.swiftmailer.org)  
php-channel-swift = 1.0.0-1.fc8
:( final requires
/usr/bin/pear  
php-cli  
php-pear(PEAR)  
* %check is not present; no test suite provide.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear channel..)
* no documentation 

MUST 
- remove php-cli from Requires (already required by pear)
- rename from pear.swiftmailer.org.xml to %{name}.xml (see Guildelines
scriptlet sample, %{name} is the better solution to avoid any conflicts)

Note (and only note) : php-channel-symfony now also use REST version as package
version ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.